build: Enable TypeScript type checking by camdecoster · Pull Request #7680 · plotly/plotly.js

camdecoster · 2026-01-02T23:26:56Z

Description

Enable TypeScript type checking.

Closes #7678.

Changes

Add set of plotly.js types
Enable type checking
Update some files to TypeScript
Use ts-node for running some scripts
Add type generation script that uses attributes files
Add type checking steps to CI

Testing

CI should cover everything
Run npm run build locally to check that everything is bundled properly by esbuild
Run plotly.js devtools and load some mocks to make sure everything is working correctly
Run npm run typecheck to perform a type check on the source code. There should be no errors:
```
$ npm run typecheck

> plotly.js@3.5.1 typecheck
> tsc --noEmit
$
```

Notes

This PR adds the TypeScript compiler and typechecking via npm script
The provided types are a combination of plotly.js types from DefinitelyTyped and the schema (with Claude combining the two). This is a first pass and the types will need to be updated as files are converted.
(Most) IDEs will read the types and provide autocompletion once files are converted over
Read the README in src/types for an overview of how the types are set up
esbuild is compatible with TypeScript already, but it doesn't do type checking. To check types you need to run npm run typecheck. VS Code will also provide feedback as you're editing files.
I converted a few simple files to TypeScript as an example. I opted to use ESM syntax for these files which necessitated some changes in the require statements for the converted files. This is due to how esbuild determines if a default import should be namespaced or not.
Some of the converted files are used in scripts not processed by esbuild. Node 18 doesn't handle TS files natively, so these scripts need to be run with ts-node, a "TypeScript execution and REPL for node.js".
The TS config is pretty lenient right now to make it easier to convert things piece by piece. Once we make enough progress, this can be tightened up.
TS is not emitting files/types right now. esbuild handles converting the TS so the TS compiler won't need to do that. It would be valuable to have the compiler write the type definition files in the future. TS doesn't emit types, but there's a type generation step that uses TS to create types from attributes files.
There's an entry point for types now, but it's pointing to the internal types which can add overhead. In the future, there will be a type build step that compiles them down to a flat file.

emilykl · 2026-01-12T21:17:01Z

 var constants = require('./constants');
 var overrideAll = require('../../plot_api/edit_types').overrideAll;
-var sortObjectKeys = require('../../lib/sort_object_keys');
+var sortObjectKeys = require('../../lib/sort_object_keys').default;


@camdecoster Is it worth considering moving away from default exports entirely as part of this transition?

It only matters when one mixes CJS and ESM. That said, I don't think that we can avoid that for a long time. I suppose we could make just pick a direction to go and standardize. I could go either way, but the esbuild docs make it clear that they don't like default exports.

emilykl · 2026-01-13T18:28:08Z

+    fillcolor?: string;
+    line?: Partial<Line>;
+    marker?: Partial<Marker>;
+    mode?: 'lines' | 'markers' | 'lines+markers' | 'none' | 'text' | 'lines+text' | 'markers+text' | 'lines+markers+text';


Does TypeScript have any support for 'flag list'-type string values such as this, where the string may consist of any number of a fixed set of values joined by a delimiter? I suppose not as it's fairly custom.

Otherwise could we use a custom type or a custom function to generate these lists of allowed values based on the flags?

Yes, it's called a union type. What's shown on 133 is an example of that (though it's only used on that line). If we needed that type elsewhere, we could define it separately and reference it within the ScatterTrace type like this:

type Mode = 'lines' | 'markers' | 'lines+markers' | 'none' | 'text' | 'lines+text' | 'markers+text' | 'lines+markers+text'; export interface ScatterTrace extends TraceBase { ..., mode: Mode; ..., }

emilykl · 2026-01-13T18:29:40Z

+ * Use specific trace types when available
+ */
+export interface GenericTrace extends TraceBase {
+    x?: any[];


I'm not sure there are any traces where x/y/z are allowed to be a type other than number[] | string[] but I could be wrong about that.

That's why it's permissive here. Once we become sure, we can change this as you suggest.

In this case maybe it would be easier to start stricter and loosen if needed?

Actually, scratch that

emilykl · 2026-01-15T20:34:17Z

@camdecoster Can you add a type-check step to the CI?

emilykl · 2026-01-15T20:39:34Z

+    yaxis?: Partial<LayoutAxis>;
+
+    // Multiple axes support (xaxis2, yaxis3, etc.)
+    [key: string]: any;


Can we tighten this layout spec here to match the plot schema?

emilykl · 2026-01-15T23:09:22Z

@camdecoster Some initial thoughts on organization of the types:

For types corresponding directly to the schema:

Group them all under a single directory (e.g. types/core/schema/), maybe even in a single file if not too unwieldy
Use nested types where useful for repeated patterns (e.g. font options); these should use some kind of consistent naming scheme

codeCraft-Ritik

Great work! The implementation is clean and easy to understand

emilykl · 2026-05-07T17:17:10Z

+ * Common properties shared by all trace types — convenience interface for
+ * gradual migration of internal code that doesn't need the full PlotData shape.
+ */
+export interface TraceBase {


What's the relationship between the TraceBase and PlotData types?

emilykl · 2026-05-07T17:19:12Z

+    _length?: number;
+    _module?: any;
+    index?: number;
+    [key: string]: any;


Is there any logic behind which keys are explicitly listed here?

emilykl · 2026-05-07T18:10:21Z

+}
+
+// ---------------------------------------------------------------------------
+// LayoutAxis (extends Axis for cartesian subplots)


small nit, but I'm not sure this comment is accurate since some of these properties seem to exist for non-cartesian axes as well

emilykl · 2026-05-07T18:15:39Z

+// Mapbox types
+// ---------------------------------------------------------------------------
+
+export interface MapboxCenter {


All of these Mapbox* types can be changed to Map* right? AFAIK the API is exactly the same.

emilykl · 2026-05-07T18:17:46Z

+    xaxis6: Partial<LayoutAxis>;
+    xaxis7: Partial<LayoutAxis>;
+    xaxis8: Partial<LayoutAxis>;
+    xaxis9: Partial<LayoutAxis>;


hm I realize this is taken from DefinitelyTyped but what about plots with more than 9 x/y axes? I don't think there's any hard upper limit

emilykl · 2026-05-07T18:18:33Z

+    hoversubplots: 'single' | 'overlaying' | 'axis';
+    calendar: Calendar;
+
+    // Dotted property paths for Plotly.relayout convenience


Why are these needed?

emilykl · 2026-05-07T18:20:16Z

+    _modeBar?: any;
+    _pushmargin?: { [key: string]: any };
+
+    [key: string]: any;


same question here, is there any reasoning behind which keys are called out explicitly?

emilykl · 2026-05-07T18:25:22Z

+/**
+ * Template figure type
+ */
+export interface TemplateFigure {


What's the difference between Template and TemplateFigure?

emilykl · 2026-05-07T18:37:04Z

Shouldn't this be generated from src/components/colorbar/attributes.js?

emilykl · 2026-05-07T18:49:24Z

Doesn't this file duplicate the info in src/traces/box/attributes.js to some extent?

emilykl · 2026-05-07T18:58:24Z

+
+| User-facing | Internal | Where defined |
+|---|---|---|
+| `Layout` | `FullLayout` | `Layout` is generated; `FullLayout extends Layout` is hand-written |


`Layout` is generated; `FullLayout extends Layout` is hand-written

This isn't currently the case based on the contents of this PR though, right? Layout seems to be hand-written.

emilykl · 2026-05-07T19:20:39Z

+
+```ts
+/**
+ * @generates ModeBar


Should probably add some guidelines for choosing this canonical public name, since it may not always be obvious.

emilykl · 2026-05-07T19:23:15Z

+
+### 6. Replace the hand-written type in `src/types/`
+
+Find the corresponding hand-written type (likely in


Will it always be obvious which hand-written type corresponds to the attributes file? How do you determine for sure whether one already exists or not?

emilykl · 2026-05-07T19:24:53Z

+If the hand-written type was richer than the schema (e.g. used a narrowed
+union where the schema says `string`), document the gap in a comment or
+file an issue. Do not silently lose ergonomics — either improve the schema
+(add `values: [...]`) or layer a hand-written refinement on top.


or layer a hand-written refinement on top

I'm not sure there's really a clean way to do this using the proposed architecture

camdecoster changed the title ~~build: Enable typescript type checking~~ build: Enable TypeScript type checking Jan 2, 2026

camdecoster marked this pull request as ready for review January 2, 2026 23:54

camdecoster requested a review from emilykl January 7, 2026 16:57

camdecoster assigned emilykl Jan 7, 2026

emilykl reviewed Jan 12, 2026

View reviewed changes

emilykl reviewed Jan 13, 2026

View reviewed changes

emilykl reviewed Jan 15, 2026

View reviewed changes

archmoj mentioned this pull request Jan 27, 2026

Set default layout.axis.tickmode to 'sync' when axis is overlaying #7684

Open

codeCraft-Ritik reviewed Feb 28, 2026

View reviewed changes

camdecoster assigned camdecoster and unassigned emilykl Apr 15, 2026

camdecoster added 9 commits May 5, 2026 16:28

Linting/formatting

51001fd

Initial TS set up

cef04d2

Convert a few small files to TS

412d4b1

Update requires to handle esbuild ESM/CJS interoperability

f704542

Use ts-node for scripts using TS that run outside of esbuild

5f72cf8

Run test script with ts-node

5ed7da0

Add additional types and type generation script

f2622c5

Convert modebar attributes to TS

a131cfe

Add type generation npm scripts

de168ca

camdecoster force-pushed the cam/7678/enable-typescript-type-checking branch from 2439dad to de168ca Compare May 6, 2026 22:07

camdecoster added 5 commits May 6, 2026 16:13

Add type check steps to CI

5f8654c

Update TS docs

eebf71e

Add entry point to types

c11bca1

Update file name case check

04261b2

Linting/formatting

e69463a

camdecoster requested a review from emilykl May 7, 2026 16:07

emilykl reviewed May 7, 2026

View reviewed changes


		### 6. Replace the hand-written type in `src/types/`

		Find the corresponding hand-written type (likely in

Uh oh!

Conversation

camdecoster commented Jan 2, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description

Changes

Testing

Notes

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

camdecoster Jan 13, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

emilykl Jan 15, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

emilykl commented Jan 15, 2026

Uh oh!

Choose a reason for hiding this comment

Uh oh!

emilykl commented Jan 15, 2026

Uh oh!

codeCraft-Ritik left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

emilykl May 7, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

camdecoster commented Jan 2, 2026 •

edited

Loading

camdecoster Jan 13, 2026 •

edited

Loading

emilykl Jan 15, 2026 •

edited

Loading

emilykl May 7, 2026 •

edited

Loading